Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cheukyin699/fix docs again and again #489

Merged
merged 8 commits into from
Sep 25, 2020

Conversation

chuck-sys
Copy link
Collaborator

Pull Request

Description

Give a brief description of your changes: I don't like how we patch things here.

@chuck-sys chuck-sys requested review from a team as code owners September 25, 2020 03:54
Copy link
Member

@bobheadxi bobheadxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this is a big update!

Do you mind if we land #484 first, since that contains some docs changes as well?

@chuck-sys
Copy link
Collaborator Author

Wow, this is a big update!

Do you mind if we land #484 first, since that contains some docs changes as well?

Yeah sure

@codecov
Copy link

codecov bot commented Sep 25, 2020

Codecov Report

Merging #489 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #489   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files          45       45           
  Lines        2494     2494           
  Branches      321      321           
=======================================
  Hits         2337     2337           
  Misses        109      109           
  Partials       48       48           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9cb544...14054f5. Read the comment docs.

@chuck-sys chuck-sys merged commit 82261dd into master Sep 25, 2020
@chuck-sys chuck-sys deleted the cheukyin699/fix-docs-again-and-again branch September 25, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants