-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cheukyin699/fix docs again and again #489
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is a big update!
Do you mind if we land #484 first, since that contains some docs changes as well?
Yeah sure |
Codecov Report
@@ Coverage Diff @@
## master #489 +/- ##
=======================================
Coverage 93.70% 93.70%
=======================================
Files 45 45
Lines 2494 2494
Branches 321 321
=======================================
Hits 2337 2337
Misses 109 109
Partials 48 48 Continue to review full report at Codecov.
|
Pull Request
Description
Give a brief description of your changes: I don't like how we patch things here.